boards/same54-xpro: configure pins for UART HW flow control & ethernet LED #20183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benpicco
requested review from
leandrolanzieri,
jia200x and
MrKevinWeiss
as code owners
github-actions
bot
added
Area: boards
There is a software controlled LED on the RJ45 connector. Export it via SAUL.
benpicco
changed the title
dylad
reviewed
Dec 14, 2023
Comment on lines
-118
to
-121
| #ifdef MODULE_PERIPH_UART_HW_FC | ||
| .rts_pin = GPIO_UNDEF, | ||
| .cts_pin = GPIO_UNDEF, | ||
| #endif |
There was a problem hiding this comment.
It's not needed, we check .tx_pad == UART_PAD_TX_0_RTS_2_CTS_3
dylad
added
the
CI: ready for build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
On EXT1 the pins for RTS and CTS are accessible, so configure them.
Testing procedure
Issues/PRs references